Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address all collections.abc DeprecationWarnings #222

Merged
merged 1 commit into from
Sep 14, 2019

Conversation

sloria
Copy link
Contributor

@sloria sloria commented Sep 14, 2019

#215 wasn't complete--this addresses the same DeprecationWarning everywhere.

@blag blag self-requested a review September 14, 2019 18:56
Copy link
Collaborator

@blag blag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some comments to disable a flake8 check in _compat.py - that will make CI happy.

flex/_compat.py Outdated Show resolved Hide resolved
flex/_compat.py Outdated Show resolved Hide resolved
@sloria
Copy link
Contributor Author

sloria commented Sep 14, 2019

Done

Copy link
Collaborator

@blag blag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blag blag merged commit 6116ffd into pipermerriam:master Sep 14, 2019
@sloria sloria deleted the collections-imports branch September 14, 2019 19:20
@blag
Copy link
Collaborator

blag commented Sep 14, 2019

Released version 6.14.1 to PyPI and GitHub with these changes. Thanks for your contribution!

@blag
Copy link
Collaborator

blag commented Sep 14, 2019

Also, thank you for following the pull request guidelines regarding gifs of cute animals. It's a very important part of the software development process (and an excellent way to bribe us maintainers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants